terraform-aws-rds-cluster icon indicating copy to clipboard operation
terraform-aws-rds-cluster copied to clipboard

Supporting more rules for egress

Open vale21 opened this issue 1 year ago • 12 comments

what

Support the ability to specify CIDR blocks and additional security groups for egress as well

why

improve security groups

references

Fixes #164

vale21 avatar Apr 24 '23 14:04 vale21

Thank you @aknysh. Changes integrated

vale21 avatar Apr 24 '23 14:04 vale21

/test all

aknysh avatar Apr 24 '23 15:04 aknysh

/test all

aknysh avatar Apr 24 '23 17:04 aknysh

/test all

Nuru avatar Apr 26 '23 08:04 Nuru

Hello guys. Any update on this please? Is something still pending? Can it be merged?

@srhopkins @florian0410 @aknysh

vale21 avatar May 04 '23 07:05 vale21

Hello guys. Any update on this please? Is something still pending? Can it be merged?

@srhopkins @florian0410 @aknysh

vale21 avatar May 25 '23 09:05 vale21

@aknysh could you plese review the changes that I pushed? This PR is blocked since a lot of time

vale21 avatar Jun 20 '23 16:06 vale21

@aknysh @Nuru guys, I've incorporated the requested changes. can I have a review please?

vale21 avatar Jul 17 '23 12:07 vale21

@aknysh and @Nuru this seems like an easy win. What do we need to do to get this merged in? I believe @vale21 has made all the requested changes.

taliesins avatar Jul 17 '23 12:07 taliesins

@vale21 thanks for the PR.

Please see the comments. Please also format all TF code by running terraform fmt. And also, please run the following commands:

make init
make github/init
make readme

and commit the changes

thanks

Hi @aknysh, this has been done a while ago. Can you review please?

vale21 avatar Aug 30 '23 13:08 vale21

@aknysh can you re review?

hans-d avatar Mar 02 '24 00:03 hans-d

Thanks @vale21 for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]