terraform-aws-rds-cluster
terraform-aws-rds-cluster copied to clipboard
Supporting more rules for egress
what
Support the ability to specify CIDR blocks and additional security groups for egress as well
why
improve security groups
references
Fixes #164
Thank you @aknysh. Changes integrated
/test all
/test all
/test all
Hello guys. Any update on this please? Is something still pending? Can it be merged?
@srhopkins @florian0410 @aknysh
Hello guys. Any update on this please? Is something still pending? Can it be merged?
@srhopkins @florian0410 @aknysh
@aknysh could you plese review the changes that I pushed? This PR is blocked since a lot of time
@aknysh @Nuru guys, I've incorporated the requested changes. can I have a review please?
@aknysh and @Nuru this seems like an easy win. What do we need to do to get this merged in? I believe @vale21 has made all the requested changes.
@vale21 thanks for the PR.
Please see the comments. Please also format all TF code by running
terraform fmt
. And also, please run the following commands:make init make github/init make readme
and commit the changes
thanks
Hi @aknysh, this has been done a while ago. Can you review please?
@aknysh can you re review?
Thanks @vale21 for creating this pull request!
A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.
While you wait, make sure to review our contributor guidelines.
[!TIP]
Need help or want to ask for a PR review to be expedited?
Join us on Slack in the
#pr-reviews
channel.