terraform-aws-elasticsearch icon indicating copy to clipboard operation
terraform-aws-elasticsearch copied to clipboard

Parameterize access policies json for more flexibility (3rd try)

Open bmbferreira opened this issue 11 months ago • 1 comments

what

Adds a new parameter to be able to pass a json string with a custom access policy to set for the elasticsearch.

why

In my opinion, the access policies are too "opinionated" on this module, especially when it is on "vpc mode". I think it should be more flexible and allow to customize it however we want and not having it based on the iam_role_arn variable.

references

N/A

P.S.: This is already the 3rd time I'm trying to have this new parameter accepted. Please take a look at it this time 🙇 thank you. Previous tries:

  • https://github.com/cloudposse/terraform-aws-elasticsearch/pull/180
  • https://github.com/cloudposse/terraform-aws-elasticsearch/pull/155

bmbferreira avatar Dec 30 '24 10:12 bmbferreira

Hi @osterman ! Sorry to ping you and thank you for all the work on this and other modules 🙇 Do you think that this change on the module makes sense? I've been trying to have it merged for a long time now 😅 Thank you and all the best!

bmbferreira avatar Jan 10 '25 15:01 bmbferreira

@bmbferreira Hello. Sorry for the long response. If this PR is still relevant to you, I'm ready to merge it. But I can not resolve conflicts without your assistance.

CleanShot 2025-07-30 at 12 44 39@2x

goruha avatar Jul 30 '25 10:07 goruha

💥 This pull request now has conflicts. Could you fix it @bmbferreira? 🙏

mergify[bot] avatar Jul 30 '25 10:07 mergify[bot]

@bmbferreira Thanks for the contribution. I pulled your changes to #210 and will get it merged today

goruha avatar Aug 14 '25 15:08 goruha

@bmbferreira Thanks for the contribution. I pulled your changes to #210 and will get it merged today

Sorry for the delay replying to you. Thanks a lot @goruha for finally merging these changes. 🙇‍♂️

bmbferreira avatar Aug 20 '25 00:08 bmbferreira