Feat/instance profile iam

[florian0410]

what

• Enhancement of #107 + #113, due to original developer seemingly abandoning the original PR.
  • Adds service_role_name as another 'override', like instance_role_name is in the original PR.
• Allow the user of the module to specify an existing IAM Role name for the instance profile.
• Allow the user of the module to specify an existing IAM Role name for the service profile.
• This IAM role name will be used to create the instance profile that is assigned to the EC2 instances managed by Elastic Beanstalk.
• Add lifecycle create_before_destroy since some of my testings showed that we could break the environment if we remove the IAM role before Beanstalk finished to update the environment.
• Add example using nlb

why

• Some environments/users do not have the ability to create their own IAM roles/policies, for security reasons. This change allows a user to provide their own IAM role if one already exists.
• Currently the module creates an IAM role and a series of permissions for the role.
• It is hard to specify what permission to use
• We cannot entirely define the permissions to use even with extended_ec2_policy_document

references

• closes #70
• closes #107
• closes #127
• closes #113
• Give a solution for #181 (still some work to do after this)

Mentions

I reused propositions from #113 and #107 for this PR with some rebase, thank you to @bstascavage and @Jbarna

[florian0410]

/test all

[florian0410]

/test all

[nitrocode]

The create_before_destroy lifecycle sounds like it could cause other problems. I'll defer to my teammates to see if they have any issues with it.

cc: @aknysh @jamengual

[florian0410]

/test all

[florian0410]

/test all

[florian0410]

Hello @nitrocode just fixed some things according to your suggestions.

Is the security groups feature still blocking MR in this repository ?

[mergify[bot]]

This pull request is now in conflict. Could you fix it @florian0410? 🙏

[aknysh]

@florian0410 please resolve the conflicts

[aknysh]

@florian0410 please resolve the conflicts

[lbeltramino-uala]

@florian0410 please resolve the conflicts!

[lbeltramino]

@florian0410 please resolve the conflicts!

[damiromero-uala]

please resolve the conflicts! we need this

[Gowiem]

@lbeltramino-uala @lbeltramino @damiromero-uala -- At this point, I think @florian0410 is likely too busy and isn't likely to pick this one up. I would highly suggest that one of you take his work and create a new branch, work through the conflicts, and PR that. I would be happy to review, so please add me as a reviewer if you choose to do so. Thanks!