terraform-aws-elastic-beanstalk-environment icon indicating copy to clipboard operation
terraform-aws-elastic-beanstalk-environment copied to clipboard

Bring back the SSHSourceRestriction setting.

Open DangerDawson opened this issue 4 years ago • 11 comments

what

  • Bring back the SSHSourceRestriction

why

  • This got accidentally removed in a previous commit https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/commit/fe6d0d7242dff18928cc204fb3c693e104978b17#diff-7a370d8342e7203b805911c92454f0f4L494

references

  • Open ticket: https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/issues/123

DangerDawson avatar Jul 06 '20 09:07 DangerDawson

/test all

joe-niland avatar Aug 18 '20 23:08 joe-niland

/test all

joe-niland avatar Aug 19 '20 01:08 joe-niland

/rebuild-readme

joe-niland avatar Aug 19 '20 01:08 joe-niland

@DangerDawson could you please rebuild the readme by running make readme or allow access to your branch?

joe-niland avatar Aug 19 '20 02:08 joe-niland

@joe-niland I am curious, what does a readme rebuild have to do with adding a single Beanstalk setting?

razorsedge avatar Aug 31 '20 21:08 razorsedge

@razorsedge technically nothing. Normally it's required when variables.tf is changed. In this case, the test is failing, perhaps because a previous PR was merged without making sure tests pass. We should fix it on this PR.

joe-niland avatar Aug 31 '20 22:08 joe-niland

@DangerDawson please resolve the conflicts

aknysh avatar Dec 31 '21 16:12 aknysh

How can I help to get this issue with ssh_source_restriction resolved?

nathant727 avatar Mar 23 '22 02:03 nathant727

/rebuild-readme

osterman avatar Mar 23 '22 03:03 osterman

/terratest

hans-d avatar Mar 02 '24 18:03 hans-d

Thanks @DangerDawson for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]