terraform-aws-elastic-beanstalk-environment icon indicating copy to clipboard operation
terraform-aws-elastic-beanstalk-environment copied to clipboard

Allow use of existing IAM role for EC2 instance profile

Open JBarna opened this issue 4 years ago • 3 comments

What

  • Allow the user of the module to specify an existing IAM Role name for the instance profile
  • This IAM role name will be used to create the instance profile that is assigned to the EC2 instances managed by Elastic Beanstalk

why

  • Currently the module creates an IAM role and a series of permissions for the role.
  • It is not possible to specify what permissions to use
  • It is not possible to edit the permissions that are created
  • This limitation severely limits the capability of the EC2 instances if they require other permissions to operate.

references

  • This PR will close issue 70: closes#70
  • https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/issues/70

Additional information

I was unable to build the readme.md. I ran

make init
make readme/deps
make readme

and received this error

$ make readme
Package terraform-docs already installed
make: gomplate: No such file or directory
make: *** [readme/build] Error 1

Please advise how to fix those errors.

Best, Joel

JBarna avatar Mar 03 '20 03:03 JBarna

This pull request is now in conflict. Could you fix it @JBarna? 🙏

mergify[bot] avatar Dec 27 '20 20:12 mergify[bot]

@JBarna please resolve the conflicts

aknysh avatar Dec 31 '21 16:12 aknysh

still conflicts @boeser-stavvy thank you for taking care of this

aknysh avatar Feb 22 '22 17:02 aknysh

This pull request is now in conflict. Could you fix it @JBarna? 🙏

mergify[bot] avatar Mar 08 '24 19:03 mergify[bot]

This PR has been closed due to inactivity and merge conflicts. Please resolve the conflicts and reopen if necessary.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]

Thanks @JBarna for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]

[!IMPORTANT]

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]