terraform-aws-ecs-web-app icon indicating copy to clipboard operation
terraform-aws-ecs-web-app copied to clipboard

Published 20 hours ago • verified publisher icon cloudposse

chore: add load_balancing_algorithm_type variable

Open dmitrijn opened this issue 2 years ago • 6 comments
trafficstars

what

  • add load_balancing_algorithm_type variable for alb-ingress module

why

  • allow to switch between round_robin and least_outstanding_requests for alb target groups

dmitrijn avatar Sep 18 '23 13:09 dmitrijn

/terratest

Gowiem avatar Sep 18 '23 19:09 Gowiem

@dmitrijn mind looking into the various failures?

Gowiem avatar Sep 18 '23 20:09 Gowiem

@Gowiem please run tests

dmitrijn avatar Sep 19 '23 09:09 dmitrijn

/terratest

Gowiem avatar Sep 19 '23 16:09 Gowiem

@Gowiem it's not possible to run tests on terraform v5 provider. If i will update all modules it will break compatibility with v3 provider and old terraform versions < 1.0.0. imho it must be other PR with all module updates.

dmitrijn avatar Sep 20 '23 12:09 dmitrijn

@dmitrijn we do want to move towards 1.0.0 -- I would say we pull the band aid off now. If you don't want to sign up for that as part of this PR, then that is understandable, but it will block this PR.

I will surface this conversation in our maintainer slack channel. Thanks for bringing it up!

Gowiem avatar Sep 20 '23 19:09 Gowiem

/terratest

goruha avatar Apr 10 '24 15:04 goruha

Resolved conflicts

goruha avatar Apr 10 '24 15:04 goruha

/terratest

goruha avatar Apr 10 '24 15:04 goruha

@dmitrijn Merged. Thanks for your contribution

goruha avatar Apr 10 '24 15:04 goruha