terraform-aws-ecs-web-app icon indicating copy to clipboard operation
terraform-aws-ecs-web-app copied to clipboard

Clarifying GitHub OAuth token variable

Open justnom opened this issue 3 years ago • 3 comments

what

Clarifying what the github_oauth_token variable should contain.

why

The aws-codebuild module changed the default type for the github_token variable to PARAMTER_STORE from PLAINTEXT in this commit https://github.com/cloudposse/terraform-aws-codebuild/commit/d0782827c25de91f41b7ea2421ef4970f047f3be.

references

  • https://github.com/cloudposse/terraform-aws-ecs-codepipeline/pull/89

justnom avatar Dec 01 '21 16:12 justnom

Wow, this is a pretty important change! Hopefully this can get merged quickly.

nk9 avatar Jan 20 '22 23:01 nk9

/test all

Gowiem avatar Jan 21 '22 19:01 Gowiem

/test all

Gowiem avatar Apr 10 '23 21:04 Gowiem