terraform-aws-ecs-alb-service-task icon indicating copy to clipboard operation
terraform-aws-ecs-alb-service-task copied to clipboard

Published 20 hours ago • verified publisher icon cloudposse

Updating context and SG module version 4

Open jamengual opened this issue 3 years ago • 10 comments

what

  • Update context to latest version
  • Update security group module to release 4.0

why

  • to provide new SG 4.x functionality and updates

references

    • https://github.com/cloudposse/terraform-aws-security-group

jamengual avatar Dec 22 '21 05:12 jamengual

/test all

jamengual avatar Dec 22 '21 05:12 jamengual

Thanks for the contribution Pepe.

In order to migrate, the following will need to be done

  1. Review other past PRs
    • https://github.com/cloudposse/terraform-aws-efs/pull/94
    • https://github.com/cloudposse/terraform-aws-msk-apache-kafka-cluster/pull/44
  2. Deprecate old variables instead of removing them
  3. Make sure tests work
  4. Deploy the existing non-pre-release version of this module
  5. Migrate that version to this PR's version
  6. Create a migration doc
  7. Merge branches of existing open PRs (if they look OK)
  8. Tag existing PRs in this PR
  9. Go back up to "Make sure tests work"
  10. Ping @Nuru for a review
  11. Address changes and go back to "Make sure tests work"

In order to revert, the following will need to be done

  1. Go back to the pre-release version
  2. Start above from step 7

nitrocode avatar Dec 22 '21 05:12 nitrocode

/test all

jamengual avatar Dec 22 '21 05:12 jamengual

/test all

jamengual avatar Dec 22 '21 06:12 jamengual

/test all

jamengual avatar Dec 22 '21 06:12 jamengual

/test all

jamengual avatar Dec 23 '21 00:12 jamengual

/test all

jamengual avatar Dec 23 '21 00:12 jamengual

/test all

jamengual avatar Dec 23 '21 04:12 jamengual

/test all

jamengual avatar Dec 23 '21 04:12 jamengual

This pull request is now in conflict. Could you fix it @jamengual? 🙏

mergify[bot] avatar Dec 27 '21 22:12 mergify[bot]