terraform-aws-ecr icon indicating copy to clipboard operation
terraform-aws-ecr copied to clipboard

feat: add organizations as readonly access

Open dragosmc opened this issue 3 years ago • 6 comments

what

  • Add the ability to have organizations as trustees (read-only) for the ECR repository

why

  • As described in #82, it's sometimes useful to allow an entire organization to consume images from a centralized repository

references

  • closes #82

dragosmc avatar Sep 23 '21 16:09 dragosmc

Although functionally the PR is ready I want to update the readme too. Is this done automatically by the pipeline? Sorry, I couldn't find instructions on how to do it automatically.

dragosmc avatar Sep 23 '21 16:09 dragosmc

This pull request is now in conflict. Could you fix it @dragosmc? 🙏

mergify[bot] avatar Mar 21 '22 18:03 mergify[bot]

Any update on this? @dragosmc

daleric-xyz avatar Apr 14 '22 15:04 daleric-xyz

Apologies, didn't get a chance to revisit and address the comments. I expect to have an updated PR over the weekend.

dragosmc avatar Apr 16 '22 15:04 dragosmc

I believe this is ready. Unfortunately, I cannot run the tests locally due to an issue with bats on MacOS

dragosmc avatar Apr 18 '22 08:04 dragosmc

This pull request is now in conflict. Could you fix it @dragosmc? 🙏

mergify[bot] avatar Apr 22 '22 22:04 mergify[bot]

The feature introduced by this PR is very useful. @dragosmc, please could you rebase the PR?

jtyr avatar Oct 14 '22 09:10 jtyr

@dragosmc friendly ping on rebasing this as it does seem like people want this. If you can get this updated and conflicts resolved, then I'll review and we'll get this merged. Feel free to ping me when it's ready. Thanks!

Gowiem avatar May 18 '23 20:05 Gowiem

Hi @Gowiem - I'll get this rebased and changed over the weekend. 👍

dragosmc avatar May 18 '23 23:05 dragosmc

I renamed my fork's branch and this PR was closed automatically. A new one is open here https://github.com/cloudposse/terraform-aws-ecr/pull/106

dragosmc avatar May 22 '23 09:05 dragosmc