terraform-aws-ecr icon indicating copy to clipboard operation
terraform-aws-ecr copied to clipboard

Published 20 hours ago • verified publisher icon cloudposse

Allow to use ECR replication

Open dmitrijn opened this issue 2 years ago • 6 comments

  • Allow to use ECR replication
  • https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ecr_replication_configuration

Closes https://github.com/cloudposse/terraform-aws-ecr/issues/99

dmitrijn avatar Jan 04 '23 17:01 dmitrijn

can someone run tests?🙂

dmitrijn avatar Jan 10 '23 09:01 dmitrijn

@dmitrijn can you please address the linting issues in your new example as well? Thanks!

Gowiem avatar May 25 '23 21:05 Gowiem

@dmitrijn friendly ping on this -- want to wrap this up with the requested changes and we'll get it merged?

Gowiem avatar Jul 11 '23 04:07 Gowiem

@Gowiem please run tests.

dmitrijn avatar Sep 22 '23 15:09 dmitrijn

@dmitrijn thank you for the PR Please run the following commands and commit the changes:

make init
make github/init
make readme

aknysh avatar Oct 16 '23 19:10 aknysh

@dmitrijn this one is close, can you make the remaining change so this can be merged?

kevcube avatar Feb 07 '24 11:02 kevcube

This pull request is now in conflict. Could you fix it @dmitrijn? 🙏

mergify[bot] avatar Mar 07 '24 13:03 mergify[bot]

@hans-d I took this one over, can you review?

kevcube avatar Mar 07 '24 13:03 kevcube

/terratest

kevcube avatar Mar 07 '24 13:03 kevcube

@Gowiem Can you check if all is ok for you as well?

hans-d avatar Mar 07 '24 14:03 hans-d