terraform-aws-ec2-instance icon indicating copy to clipboard operation
terraform-aws-ec2-instance copied to clipboard

Add user data replace feature

Open tirumerla opened this issue 3 years ago • 3 comments

what

  • Allow flexibility to destroy and recreate ec2 instances when user data changes. See user_data_replace_on_change option
  • Not sure if this is backwards compatible, I'm testing on >=4.7.0 aws provider version.

why

  • Allow flexibility to destroy and recreate ec2 instances when user data changes.

references

  • Fixes #132

tirumerla avatar Jul 28 '22 04:07 tirumerla

I think this duplicates https://github.com/cloudposse/terraform-aws-ec2-instance/pull/123

woz5999 avatar Jul 28 '22 17:07 woz5999

I think this duplicates #123

Oops, that's right. Please let me know if i should close this and wait for the other PR to be merged. If not this PR can go in if you think other one might take little longer.

tirumerla avatar Aug 20 '22 04:08 tirumerla

co-author of #123 here. we're ready willing and able to push that through if/when the maintainers are ready. also happy to cede to this MR. let us know how we can help.

woz5999 avatar Aug 22 '22 17:08 woz5999

This pull request is now in conflict. Could you fix it @tirumerla? 🙏

mergify[bot] avatar Mar 08 '24 12:03 mergify[bot]

This PR has been closed due to inactivity and merge conflicts. Please resolve the conflicts and reopen if necessary.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]

Thanks @tirumerla for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]

[!IMPORTANT]

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]