terraform-aws-ec2-instance icon indicating copy to clipboard operation
terraform-aws-ec2-instance copied to clipboard

allow assigning instance to a capacity reservation id

Open joelsdc opened this issue 3 years ago • 7 comments

what

  • allow assigning instance to a capacity reservation id

why

  • When using capacity reservations for certain EC2 instances, you need to specify the capacity id at launch to assign it.

references

  • See: https://github.com/cloudposse/terraform-aws-ec2-instance/issues/120

joelsdc avatar Apr 13 '22 03:04 joelsdc

This is a very simple change. As it involves adding a new config option, where should I add it?

joelsdc avatar Apr 13 '22 03:04 joelsdc

/test all

Gowiem avatar Apr 14 '22 15:04 Gowiem

@joelsdc can you open this PR under your personal GH account OR allow Cloud Posse access to the fork you made? Our auto-format CI is failing as it cannot access your fork right now:

  Initialized empty Git repository in /__w/terraform-aws-ec2-instance/terraform-aws-ec2-instance/.git/
  /usr/bin/git remote add origin https://github.com/TRIPP-Inc/terraform-aws-ec2-instance
  Error: fatal: unsafe repository ('/__w/terraform-aws-ec2-instance/terraform-aws-ec2-instance' is owned by someone else)
  To add an exception for this directory, call:

Gowiem avatar Apr 14 '22 15:04 Gowiem

This pull request is now in conflict. Could you fix it @joelsdc? 🙏

mergify[bot] avatar Jun 17 '22 13:06 mergify[bot]

Hi guys, sorry for the delay!

I wasn't sure what is the correct user / team to add with write access, so I added the following two:

image

Let me know if you need anything else from our end.

Thanks!

joelsdc avatar Jul 21 '22 04:07 joelsdc

Regarding the conflicts: I can't see the logs (probably due to the time since I opened this PR until now that I've got some cycles for this).

Can you re-run the /test all so I can see what is wrong and fix it?

Thanks!

joelsdc avatar Jul 21 '22 04:07 joelsdc

/rebuild-readme

joe-niland avatar Jul 21 '22 05:07 joe-niland

This pull request is now in conflict. Could you fix it @joelsdc? 🙏

mergify[bot] avatar Mar 08 '24 12:03 mergify[bot]

This PR has been closed due to inactivity and merge conflicts. Please resolve the conflicts and reopen if necessary.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]

Thanks @joelsdc for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]

[!IMPORTANT]

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]