Add user_data_replace_on_change

[bwmetcalf]

what

• Add user_data_replace_on_change parameter to allow rebuilding of instances when user data changes.

why

• Setting user_data_replace_on_change to true will restore old behavior.

references

• https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/instance#user_data_replace_on_change

[woz5999]

/test all

[woz5999]

@Gowiem i believe the bridgecrew stuff has been resolved, but the test still seems to be failing. any idea?

[Gowiem]

@woz5999 BridgeCrew is great but also a PITA. I wouldn't worry about it too much since it's not blocking this.

I would however run this by #contributors considering it's enforcing AWS provider 4.7.0 and above. I'm not sure if the core gents would agree that we should do that just yet.

[bwmetcalf]

Among other things, let's not require AWS provider v4 yet.

OK. 4.7.0 of the AWS provider is the earliest version that supports user_data_replace_on_change, so I'll leave this open for now.

[BGarber42]

Any chance on this getting revisited?

[mergify[bot]]

This pull request is now in conflict. Could you fix it @bwmetcalf? 🙏

[mergify[bot]]

This PR has been closed due to inactivity and merge conflicts. Please resolve the conflicts and reopen if necessary.

[mergify[bot]]

Thanks @bwmetcalf for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[Gowiem]

@bwmetcalf want to work through the conflicts and rebuild README (via make init && make readme) and we'll work on this one? I saw you comment /open and this looks like a legit change, so I say we push it forward. Make those changes and ping me when you're ready!

[mergify[bot]]

This pull request now has conflicts. Could you fix it @bwmetcalf? 🙏

[mergify[bot]]

This PR has been closed due to inactivity and merge conflicts. Please resolve the conflicts and reopen if necessary.

[mergify[bot]]

Thanks @bwmetcalf for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[mergify[bot]]

This pull request now has conflicts. Could you fix it @bwmetcalf? 🙏

[mergify[bot]]

This PR has been closed due to inactivity and merge conflicts. Please resolve the conflicts and reopen if necessary.

[mergify[bot]]

Thanks @bwmetcalf for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[mergify[bot]]

💥 This pull request now has conflicts. Could you fix it @bwmetcalf? 🙏