terraform-aws-components icon indicating copy to clipboard operation
terraform-aws-components copied to clipboard

A required `region` input parameter is missing in `variables.tf` of the module `modules/account-map/iam-roles`

Open iliazlobin opened this issue 3 years ago • 1 comments

Description

The variable region referenced in a terraform_remote_state data source definition of the module modules/account-map/iam-roles is missing in variables.tf

The modules/account-map/iam-roles module is generally used in many upper level modules: image

It's used for the reason of deriving the assumption role (or profile) to configure AWS provider.

Expected Behavior

Terraform doesn't trigger an error when launching a plan command and the AWS provider is given the right role to assume depending on how account-map is laid out.

Steps to Reproduce

Set up an atmos stack with one of the modules that makes use of iam-roles and run terraform plan or an atmos wrapper command atmos terraform plan iam-primary-roles -s gbl-identity

iliazlobin avatar May 20 '21 12:05 iliazlobin

Our apologies, but these components are not quite ready for production use. We currently have 20+ PRs opened to fix all the problems. In this particular case, the published version of iam-roles uses the obsolete tfstate.tf pattern for retrieving remote state (see #324). Please wait for the updated version that will use remote-state.tf.

Nuru avatar Jun 24 '21 19:06 Nuru

This was fixed by #438 if not earlier

Nuru avatar Oct 11 '22 20:10 Nuru