terraform-aws-codebuild icon indicating copy to clipboard operation
terraform-aws-codebuild copied to clipboard

Published 20 hours ago • verified publisher icon cloudposse

Aws v4 refactor

Open denissimonovski opened this issue 2 years ago • 20 comments

what

  • Refactoring the module to use the S3 bucket module
  • Use an AWS provider > v4.9.x
  • Use terraform version > v1.0

why

  • So that we can continue to build newer features into this module

references

  • closes #104
  • #104

denissimonovski avatar Jul 04 '22 12:07 denissimonovski

@Nuru I saw your comment here, and I made the refactoring to use the s3 module as you mentioned. Can you review the PR, and help me with the bridgecrew issue?

denissimonovski avatar Jul 07 '22 15:07 denissimonovski

@nitrocode can you help me with this PR?

denissimonovski avatar Jul 08 '22 16:07 denissimonovski

/test all

nitrocode avatar Jul 12 '22 02:07 nitrocode

/test all

Nuru avatar Jul 15 '22 00:07 Nuru

/test all

nitrocode avatar Jul 21 '22 00:07 nitrocode

@nitrocode can you please run the tests again?

denissimonovski avatar Jul 21 '22 08:07 denissimonovski

@nitrocode can you please re-run the tests now?

denissimonovski avatar Jul 26 '22 16:07 denissimonovski

@nitrocode can you please re-run the tests?

denissimonovski avatar Aug 02 '22 20:08 denissimonovski

/test all

joe-niland avatar Aug 02 '22 20:08 joe-niland

@joe-niland can you please re-run the tests?

denissimonovski avatar Aug 09 '22 14:08 denissimonovski

/test all

joe-niland avatar Aug 09 '22 18:08 joe-niland

@joe-niland can you please re-run the tests again 🙏 ❔

denissimonovski avatar Aug 10 '22 17:08 denissimonovski

/test all

joe-niland avatar Aug 11 '22 00:08 joe-niland

Looks like the error on the list() function is due to an old module in examples/vpc/main.tf

https://github.com/cloudposse/terraform-aws-codebuild/blob/6c270938df7a5e0c4dadda0a8fa53547f89fe060/examples/vpc/main.tf#L13-L15

You may need to bump the subnet and vpc modules. I would bump those to the latest and plan it locally to ensure you have the correct inputs set (It will be much faster doing that locally than bumping the version and requesting someone to rerun the tests).

nitrocode avatar Aug 11 '22 02:08 nitrocode

@nitrocode @joe-niland I made the changes and tested them locally this time, and the plan was successful: Plan: 42 to add, 0 to change, 0 to destroy. Can you please re-run the tests now?

denissimonovski avatar Aug 11 '22 09:08 denissimonovski

/test all

joe-niland avatar Aug 11 '22 10:08 joe-niland

@nitrocode, @joe-niland it passed all the tests now. I'll be waiting for feedback or for a merge.

denissimonovski avatar Aug 11 '22 12:08 denissimonovski

@nitrocode when can we expect a review/merge on this?

denissimonovski avatar Sep 02 '22 09:09 denissimonovski

@joe-niland @Nuru when can we expect a review/merge on this?

denissimonovski avatar Sep 20 '22 14:09 denissimonovski

@nitrocode @joe-niland @Nuru when can we expect a review/merge on this?

denissimonovski avatar Oct 11 '22 18:10 denissimonovski

Superseded by AWS V5 Upgrade

max-lobur avatar Nov 10 '23 21:11 max-lobur

Related pr https://github.com/cloudposse/terraform-aws-codebuild/pull/126

Thanks @denissimonovski @max-lobur and the reviewers for making it possible to migrate to v4 and v5 provider versions

nitrocode avatar Nov 11 '23 14:11 nitrocode