terraform-aws-cloudfront-s3-cdn icon indicating copy to clipboard operation
terraform-aws-cloudfront-s3-cdn copied to clipboard

Version 5.0.0 of the aws provider contains breaking changes for this module

Open jake-naughton opened this issue 1 year ago • 2 comments

Describe the Bug

This module fails to build when using AWS provider with version >= v5.0.0

As outlined in the AWS provider release notes:

https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0

source_json and override_json have been removed -- use source_policy_documents and override_policy_documents, respectively, instead.

Expected Behavior

Should be able to run terraform plan / apply on the module without it failing using AWS provider > v5.0.0

Steps to Reproduce

Set the AWS provider to

required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = ">= 5"
    }
  }

And run terraform plan or apply on this module.

Screenshots

Screen Shot 2023-05-28 at 10 30 47 pm

Environment

  • Module version 0.90.0
  • Terraform version 1.3.9
  • AWS provider version 5.0.0

Additional Context

No response

jake-naughton avatar May 28 '23 12:05 jake-naughton

we need this changes to be adapted for version 0.63.0 since I'm using tf13

Vigneshwar-Mahendran avatar Jun 30 '23 12:06 Vigneshwar-Mahendran

What at least could be done here is to add a constraint of < 5 in the versions.tf as otherwise, there's no easy way to make it work

rafaljanicki avatar Nov 14 '23 08:11 rafaljanicki