terraform-aws-cloudfront-s3-cdn icon indicating copy to clipboard operation
terraform-aws-cloudfront-s3-cdn copied to clipboard

Published 20 hours ago • verified publisher icon cloudposse

feat: add origin-shield

Open syphernl opened this issue 3 years ago • 11 comments
trafficstars

what

  • Add variables to enable the Origin Shield for the CloudFront distribution

why

  • Using Origin Shield can help reduce the load on your origin.

references

  • https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudfront_distribution#origin_shield
  • Also implemented recently in other CF module: https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/78

syphernl avatar Jan 11 '22 11:01 syphernl

✅ Verified on my own stack that it works.

The automated tests however will likely only work once https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/208 has been merged since the AWS Provider is now explicitly checking for a value to be set for ssl_support_method.

syphernl avatar Jan 11 '22 13:01 syphernl

This pull request is now in conflict. Could you fix it @syphernl? 🙏

mergify[bot] avatar Jan 12 '22 19:01 mergify[bot]

/rebuild-readme

korenyoni avatar Jan 12 '22 19:01 korenyoni

/test all

korenyoni avatar Jan 12 '22 19:01 korenyoni

So @syphernl looks good, not requesting any changes but want to get @osterman and @Nuru's opinions on what I've identified.

korenyoni avatar Jan 12 '22 21:01 korenyoni

@korenyoni I have changed the local into a var as @osterman suggested.

syphernl avatar Jan 13 '22 07:01 syphernl

Thanks @syphernl —

@osterman please take another look. Deferring approval to you.

korenyoni avatar Jan 13 '22 15:01 korenyoni

/test all

korenyoni avatar Jan 13 '22 15:01 korenyoni

Hi @syphernl —

I've spoken to @Nuru who needs more time to be able to get a good look at this.

korenyoni avatar Feb 10 '22 19:02 korenyoni

@korenyoni @Nuru Do you have any updates regarding this? Our project development is nearing completion and we'd like to enable the Origin Shield for this soon.

syphernl avatar Mar 14 '22 14:03 syphernl

@korenyoni @Nuru Do you have any updates regarding this? Our project development is nearing completion and we'd like to enable the Origin Shield for this soon.

At the moment it's in @Nuru 's hands.

From @Nuru :

I had to put this on hold because of the AWS 4.0 upgrade.

korenyoni avatar Mar 14 '22 15:03 korenyoni

I implemented the non-breaking-change portion of this in #247

alexjurkiewicz avatar Oct 24 '22 00:10 alexjurkiewicz