atmos icon indicating copy to clipboard operation
atmos copied to clipboard

stop process stack with command atmos vendor pull

Open haitham911 opened this issue 1 year ago • 1 comments

what

  • Do not process stack configs when executing command atmos vendor pull and the stack flag is not specified
  • Add AtomsValidateOption to checkAtmosConfig to disable or enable check stack

why

  • Atmos vendor should not require stack configs if the stack flag is not provided

references

  • DEV-2689
  • https://linear.app/cloudposse/issue/DEV-2689/atmos-vendor-should-not-require-stack-configs image (1) image (2)

Summary by CodeRabbit

  • New Features

    • Enhanced command functionality to handle the "stack" flag, improving CLI configuration initialization.
    • Introduced a new configuration structure for more flexible Atmos configuration checks.
  • Bug Fixes

    • Updated error handling to prevent simultaneous processing of conflicting flags ("component" with "stack" and "component" with "tags").
    • Improved clarity of error messages related to CLI configuration initialization failures.

haitham911 avatar Oct 21 '24 17:10 haitham911

[!WARNING]

Rate limit exceeded

@aknysh has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 16 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Files that changed from the base of the PR and between ad800b3412b3506852be01e2803f068b885827cf and c5e89e45e8f784caf505bed7aa1c0c0aaf4bc771.

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request involve modifications to the vendorPullCmd command in the cmd/vendor_pull.go file, specifically replacing the previous call to checkAtmosConfig() with a new implementation that includes a parameter for checking the stack. The internal/exec/vendor_utils.go file sees updates to the ExecuteVendorPullCommand function, adding checks for the "stack" flag and refining error handling for conflicting flags. Additionally, the checkAtmosConfig function in cmd/cmd_utils.go has been enhanced for configurability through a new structure and functional options.

Changes

File Path Change Summary
cmd/vendor_pull.go Replaced checkAtmosConfig() with checkAtmosConfig(WithStackValidation(cmd.Flag("stack").Changed)), adding stack flag handling.
internal/exec/vendor_utils.go Updated ExecuteVendorPullCommand to include a check for the "stack" flag and enhanced error handling for conflicting flags.
cmd/cmd_utils.go Introduced ValidateConfig struct, AtmosValidateOption type, and modified checkAtmosConfig to accept options for improved configurability.
examples/quick-start-advanced/Dockerfile Updated GEODESIC_VERSION from 3.2.0 to 3.3.0 and ATMOS_VERSION from 1.93.0 to 1.97.0.
go.mod Updated versions for several dependencies: bubbletea to v1.1.2, lipgloss to v0.13.1, color to v1.18.0, and ansi to v0.4.0.
website/docs/integrations/atlantis.mdx Enhanced documentation for Atlantis integration with Atmos, including new configuration methods and examples.

Possibly related PRs

  • #730: This PR modifies the ExecuteAtmosVendorInternal function in internal/exec/vendor_utils.go, which is related to the changes made in the ExecuteVendorPullCommand function in the same file in the main PR, as both involve handling vendor configurations.
  • #738: This PR updates the ExecuteVendorPullCommand function in internal/exec/vendor_utils.go, which directly relates to the changes in the main PR that also involve modifications to the same function for handling the stack flag.
  • #736: This PR enhances the ReadAndProcessVendorConfigFile function in internal/exec/vendor_utils.go, which is relevant to the changes in the main PR that involve the checkAtmosConfig function and its handling of vendor configurations.

Suggested labels

no-release

Suggested reviewers

  • hans-d
  • gberenice

Poem

In the burrow where changes bloom,
Flags and commands find more room.
With a hop and a skip, we refine,
Pulling vendors, all in line!
A stack here, a check there,
Our code dances with flair! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 21 '24 17:10 coderabbitai[bot]

These changes were released in v1.97.0.

github-actions[bot] avatar Oct 30 '24 12:10 github-actions[bot]