atmos icon indicating copy to clipboard operation
atmos copied to clipboard

fix check the version if config broken

Open haitham911 opened this issue 1 year ago • 2 comments

what

  • atmos version should work regardless if the configs are broken

why

  • atmos version should work regardless if the configs are broken, because sometimes it's broken because the version is too old.

references

  • DEV-2376
  • https://linear.app/cloudposse/issue/DEV-2376/unable-to-run-atmos-version-to-check-the-version-of-atmos-after

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced error handling for CLI configuration errors, enabling the program to continue running when the "version" command is invoked.
    • Preserved existing exit behavior for other commands when encountering configuration errors.
  • New Features
    • Introduced a utility function to identify if the "version" command is being executed, streamlining command handling.

run cmd atmos version before changes 2024-10-21 23_21_34-Window run cmd atmos version after changes 2024-10-21 23_22_57-Window

haitham911 avatar Oct 20 '24 08:10 haitham911

📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request modify the error handling logic within the Execute function of the cmd/root.go file. The new logic introduces a conditional check to determine if the command being executed is a version command, allowing the program to log errors without exiting in this case. For all other commands, the original behavior of terminating the program on error is retained. Additionally, a new utility function isVersionCommand is introduced in cmd/cmd_utils.go to facilitate this check.

Changes

File Change Summary
cmd/root.go Modified error handling in Execute function to log errors without exiting if the command is "version"; retains exit behavior for other commands.
cmd/cmd_utils.go Added isVersionCommand function to check if the command-line arguments indicate a version request.

Possibly related PRs

  • #736: This PR introduces the SearchConfigFile function, which enhances the handling of configuration files, similar to the changes in error handling and configuration initialization in the main PR. Both PRs focus on improving how configuration-related errors are managed and how configurations are loaded.

Suggested labels

minor

Suggested reviewers

  • osterman
  • aknysh
  • johncblandii

Poem

🐇 In the land of code, where errors roam,
A check was added to let them comb.
If "version" is called, we'll log with cheer,
But for other commands, the exit is near.
A hop and a skip, the logic is clear,
In the garden of code, we have nothing to fear! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 20 '24 08:10 coderabbitai[bot]

@haitham911 please post screenshot as well

osterman avatar Oct 21 '24 17:10 osterman

These changes were released in v1.96.0.

github-actions[bot] avatar Oct 29 '24 05:10 github-actions[bot]