atmos icon indicating copy to clipboard operation
atmos copied to clipboard

Fix Docker build: pin Helm 3.x and helm-diff v3.9.x

Open osterman opened this issue 3 months ago • 6 comments

what

  • Pin Helm to 3.16.4-1 for consistency with the rest of the codebase
  • Pin helm-diff plugin to v3.9.14 for Helm 3 compatibility

why

The Cloud Posse package repository updated Helm to 4.0.1, which broke the Docker build. The latest helm-diff plugin uses a plugin.yaml format incompatible with Helm 3.x, and Helm 4.x requires plugin verification that helm-diff doesn't support. Pinning both versions ensures a working build while maintaining consistency with Helm 3 used elsewhere.

references

  • Docker build failure in CI: Error: plugin source does not support verification

Summary by CodeRabbit

  • Chores
    • Pinned dependency versions to specific releases for improved build reproducibility and stability.

✏️ Tip: You can customize this high-level summary in your review settings.

osterman avatar Dec 10 '25 19:12 osterman

[!IMPORTANT]

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

mergify[bot] avatar Dec 10 '25 19:12 mergify[bot]

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

github-actions[bot] avatar Dec 10 '25 19:12 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 73.11%. Comparing base (0a2c722) to head (041276f). :warning: Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1857      +/-   ##
==========================================
+ Coverage   73.08%   73.11%   +0.03%     
==========================================
  Files         550      550              
  Lines       53168    53176       +8     
==========================================
+ Hits        38859    38882      +23     
+ Misses      11453    11437      -16     
- Partials     2856     2857       +1     
Flag Coverage Δ
unittests 73.11% <ø> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more. see 8 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 10 '25 19:12 codecov[bot]

[!CAUTION]

Review failed

The head commit changed during the review from 81d97c92901bbf4262ee29a84ebd195858d82f76 to 041276fed4e9d14f69c67b8612a8f61360299728.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch osterman/fix-list-json-yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 10 '25 19:12 coderabbitai[bot]

📝 Walkthrough

Walkthrough

Dockerfile updated to pin explicit versions for Helm (3.16.4-1) and the helm-diff plugin (v3.9.14), replacing previously unpinned installations. Inline comments updated accordingly.

Changes

Cohort / File(s) Summary
Version pinning
Dockerfile
Replaces unpinned helm installation with version 3.16.4-1; updates helm-diff plugin installation to explicitly target version v3.9.14 instead of latest; comments adjusted to reflect version constraints

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

patch

Suggested reviewers

  • aknysh

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions pinning Helm 3.x and helm-diff, but the actual objective is fixing Docker build by adding --verify=false flag for Helm 4.x compatibility. Update the title to reflect the actual change: 'Fix Docker build: add --verify=false to helm plugin install' or similar, to match the PR's true objective of Helm 4.x compatibility.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch osterman/fix-list-json-yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 10 '25 19:12 coderabbitai[bot]