atmos icon indicating copy to clipboard operation
atmos copied to clipboard

fix: update test snapshots for new pager defaults and improve error messages

Open osterman opened this issue 5 months ago • 1 comments

what

  • Updated test snapshots to reflect the new pager default value (false/"0" instead of true/"1")
  • Removed spurious "Failed to use pager" debug messages from stderr snapshots
  • Enhanced error messages to include actual error details when pager fails

why

  • Tests were failing on main branch after PR #1430 changed the default pager setting from true to false
  • The PR updated some snapshots but missed updating the terminal.pager values in two critical test snapshots
  • The test fixture tests/fixtures/scenarios/atmos-cli-imports/atmos.yaml imports from the live main branch (https://raw.githubusercontent.com/cloudposse/atmos/refs/heads/main/atmos.yaml), which means tests break when defaults change after merge
  • The "Failed to use pager" message was not helpful for debugging as it didn't include the actual error

references

  • Fixes test failures introduced after merging #1430
  • The root issue is that test fixtures dynamically import from GitHub's main branch, creating a fragile dependency

🤖 Generated with Claude Code

osterman avatar Sep 24 '25 14:09 osterman

💥 This pull request now has conflicts. Could you fix it @osterman? 🙏

mergify[bot] avatar Sep 27 '25 21:09 mergify[bot]