atmos icon indicating copy to clipboard operation
atmos copied to clipboard

Move CI env helpers to test file

Open osterman opened this issue 5 months ago • 2 comments

Summary

  • restrict CI env helpers to tests only
  • remove ci_env.go from testutils package
  • keep package buildable with minimal testutils.go

Testing

  • make lint (fails: can't load config)
  • make testacc-cover (interrupted)
  • go test ./internal/testutils -run TestPreserveRestoreCIEnvVars (pass)
  • go test ./... (interrupted)

https://chatgpt.com/codex/tasks/task_b_6859b2092c788332825df3e63fbe4266

osterman avatar Jun 23 '25 20:06 osterman

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (DEV-2965/implement-atmos-telemetry@c0ae6cf). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/testutils/ci_env.go 82.60% 3 Missing and 1 partial :warning:
Additional details and impacted files
@@                          Coverage Diff                          @@
##             DEV-2965/implement-atmos-telemetry    #1333   +/-   ##
=====================================================================
  Coverage                                      ?   51.07%           
=====================================================================
  Files                                         ?      244           
  Lines                                         ?    26113           
  Branches                                      ?        0           
=====================================================================
  Hits                                          ?    13338           
  Misses                                        ?    11127           
  Partials                                      ?     1648           
Flag Coverage Δ
unittests 51.07% <82.60%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 23 '25 22:06 codecov[bot]

💥 This pull request now has conflicts. Could you fix it @osterman? 🙏

mergify[bot] avatar Jun 24 '25 11:06 mergify[bot]