cloudnative-pg icon indicating copy to clipboard operation
cloudnative-pg copied to clipboard

feat: add additional labels for pod monitor in Cluster

Open ma-ts opened this issue 1 year ago • 10 comments

Adds the possibility to add additional labels to just the pod monitor. Currently, this is already possible by setting them on the Cluster object, but then a significant amount of resources get labeled with labels that are not relevant there. This is to support multi-tenant Prometheus situations where there might be separate Prometheus scrapers

Fixes: #4435

ma-ts avatar May 05 '24 06:05 ma-ts

:exclamation: By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested :arrow_backward: or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

github-actions[bot] avatar May 05 '24 06:05 github-actions[bot]

Any chance this one get approval ? :-)

We can't use .spec.monitoring.enablePodMonitor: true for this exact same reason (mutiple prometheus instances in the k8s cluster) and have to manage PodMonitor by ourselves because of the inability to specify a custom prometheus label.

rdegez avatar Sep 13 '24 12:09 rdegez