charts icon indicating copy to clipboard operation
charts copied to clipboard

Add support for additionalCommandArgs and configurable secretKey fields in barmanObjectStore. (fixes #653)

Open austinmarten1 opened this issue 8 months ago • 4 comments

  • Add accessKeyIdField and secretAccessKeyField to backups.secret for custom S3 credential key fields

  • Add additionalCommandArgs support for both wal and data sections in barmanObjectStore

    Fixes #653

austinmarten1 avatar Aug 21 '25 20:08 austinmarten1

+1

patstevens4 avatar Aug 27 '25 20:08 patstevens4

+1

ncwade avatar Sep 17 '25 13:09 ncwade

Please note that if custom S3 credential key fields are set and a user passes S3 creds directly in the values (such as backups.s3.accessKey and backups.s3.secretKey), the generated secret will still use the hardcoded ACCESS_KEY_ID and ACCESS_SECRET_KEY strings, causing a mismatch in the barman storage config. The same applies to the recovery S3 secret.

Additionally, this change doesn't impact the barman config when recovery is configured in the chart. You would need to add the same fields from .Values.backups.secret to .Values.recovery.secret. (I guess recovery is technically out of scope here, but this would also greatly help my use case 😃)

Helps my use case as well! I can add it in here.

austinmarten1 avatar Sep 22 '25 18:09 austinmarten1

Looks good, small nitpick about formatting.

Done

austinmarten1 avatar Sep 23 '25 12:09 austinmarten1