charts icon indicating copy to clipboard operation
charts copied to clipboard

ci: cancel concurrent lint and test workflows

Open m4s-b3n opened this issue 10 months ago • 5 comments

This pull request introduces concurrency settings to multiple GitHub Actions workflows to prevent overlapping runs and ensure that only the latest run is processed. The most important changes include the addition of concurrency groups and the cancellation of in-progress runs.

Concurrency settings added to GitHub Actions workflows:

  • .github/workflows/lint.yml: Added concurrency settings to group by workflow and reference, and cancel in-progress runs.
  • .github/workflows/tests-cluster-chainsaw.yaml: Added concurrency settings to group by workflow and reference, and cancel in-progress runs.
  • .github/workflows/tests-operator.yml: Added concurrency settings to group by workflow and reference, and cancel in-progress runs.

m4s-b3n avatar Feb 19 '25 20:02 m4s-b3n

@itay-grudev this one might spare you some approvals / pending workflows

m4s-b3n avatar Feb 21 '25 23:02 m4s-b3n

Isn't this useful sometimes? If you commit quickly, but the old CI pipeline failed as well. It helps you narrow the source of the issue?

itay-grudev avatar Feb 22 '25 20:02 itay-grudev

It would be super nice if the tests ran without approval, as long as only chart files have been changed. I haven't looked into that. I am way more familiar with GitLab CI, than GitHub Actions.

itay-grudev avatar Feb 22 '25 20:02 itay-grudev

Isn't this useful sometimes? If you commit quickly, but the old CI pipeline failed as well. It helps you narrow the source of the issue?

If you don't wait for the result it might not be worth it ;) but for you as a maintainer it would eventually be easier to decide wich workflows really need approval. I feel that useful in my workflows, but as you say nothing comes without a tradeoff ...

m4s-b3n avatar Feb 22 '25 21:02 m4s-b3n

It would be super nice if the tests ran without approval, as long as only chart files have been changed. I haven't looked into that. I am way more familiar with GitLab CI, than GitHub Actions.

Did Gitlab in the past a lot but nowadays mostly GitHub. If you need support on that let me know. I'd love to help :+1:

m4s-b3n avatar Feb 22 '25 21:02 m4s-b3n

@sxd I'm not sure I want this. It's still quite useful to see all failures, and the tests here are inexpensive.

itay-grudev avatar Jul 11 '25 10:07 itay-grudev