charts icon indicating copy to clipboard operation
charts copied to clipboard

Add support for env vars

Open mrpotato3 opened this issue 1 year ago • 2 comments

I would like to suggest adding support for defining environment variables in the Helm chart, as indicated in the documentation: CloudNative PG - Cluster Configuration.

This feature would enhance the flexibility of the Helm chart and allow users to customize their deployments more effectively.

Thank you for the amazing work on this project.

mrpotato3 avatar Sep 02 '24 12:09 mrpotato3

A while ago I added that in #224, but that PR was eventually dropped. We can still get the relevant code from there and create a separate PR with it.

itay-grudev avatar Sep 04 '24 01:09 itay-grudev

I need to set ENABLE_AZURE_PVC_UPDATES... other than switchoverDelay and failoverDelay and the enablePDB ... the chart has everything we need!

jmealo avatar Dec 05 '24 21:12 jmealo

Hi, @mrpotato3. I'm Dosu, and I'm helping the charts team manage their backlog. I'm marking this issue as stale.

Issue Summary

  • You proposed adding support for defining environment variables in the Helm chart for better deployment customization.
  • @itay-grudev mentioned that similar functionality was attempted in PR #224, which was not merged, but could be reused.
  • @jmealo expressed a need for specific environment variables like ENABLE_AZURE_PVC_UPDATES.

Next Steps

  • Please let us know if this issue is still relevant to the latest version of the charts repository by commenting here.
  • If there is no further activity, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

dosubot[bot] avatar Apr 10 '25 16:04 dosubot[bot]

ENABLE_AZURE_PVC_UPDATES is no longer required. The chart should still expose this incase folks need to turn on debug logging or pass additional values.

jmealo avatar Apr 17 '25 17:04 jmealo

I haven't used the chart since 2024. If I'm not mistaken, is this already exposed here: https://github.com/cloudnative-pg/charts/blob/bacf3a03a3e47889ebaf23b4c9ca0e14abcbef22/charts/cloudnative-pg/values.yaml#L97C1-L97C14

There doesn't appear to be a way to set this for the Cluster though? 🤔

jmealo avatar Apr 17 '25 17:04 jmealo

@itay-grudev this FR not completed, as what @jmealo refers to is operator helm chart, not cluster helm chart, I will create PR to fill that gap.

I faced near-same issue due to using Ceph Rados as S3 and requirement to adjust settings https://www.beyondwatts.com/posts/debugging-barman-xamzcontentsha256mismatch-error-after-upgrading-to-postgresql175/

Ideally this settings can be set in s3 configuration, but as a quick fix without touching operator code adding envs is a good way to go.

dragoangel avatar Sep 23 '25 12:09 dragoangel