cloudnative-pg
feat(cloudnative-pg): add metrics from cluster-example-monitoring.yaml
This adds the metrics from cloudnative-pg/blob/docs/src/samples/cluster-example-monitoring.yaml
Since these metrics are in the sample, it is nice to have them in the defaults.
Good catch, thanks! But it looks like we are also missing a few other ones, no? I think it's because at some point we switched to deploying them by default with the plain manifests and forgot about updating them here. I'd rather not duplicate them though
I think this has all the same metrics as the sample files, but my by hand reconcile may have missed something...
ok, now i got it, it's in sync with the default ones we deploy with manifests, see https://github.com/cloudnative-pg/cloudnative-pg/blob/main/releases/cnpg-1.20.0.yaml#L12160. The ones you are adding come from the example one: https://github.com/cloudnative-pg/cloudnative-pg/blob/main/docs/src/samples/cluster-example-monitoring.yaml#L27. I'm not sure it was a deliberate choice not to include those by default tbh, I'll have to check!
Interesting, I didn't realize they were also in the release yaml. I'd love for all 3 to have the same metrics. This way I've got a consistent metrics set in whichever mode I've loaded them from.
Yes, either by adding or removing these everywhere. I'm checking if there was a reason not to include them in the default queries, i'll let you know 🙏