pkg-cloudinary-core icon indicating copy to clipboard operation
pkg-cloudinary-core copied to clipboard

Published 20 hours ago • verified publisher icon cloudinary

Fix: Typescript Type Definition for Configuration.Options.secure_distribution type

Open seibert-io opened this issue 5 years ago • 0 comments

The Type definition for Configuration.Options.secure_distribution is wrong. Type definitions declare it as boolean | undefined https://github.com/cloudinary/pkg-cloudinary-core/blob/47ffb3b0c1a163fb1b4e2fc74931c1992a23122b/cloudinary-core.d.ts#L813, wheres Usage inline-docs and application behavior indicate it must be a string containing the cname to use, not just a boolean value.

See

  • https://github.com/cloudinary/pkg-cloudinary-core/blob/47ffb3b0c1a163fb1b4e2fc74931c1992a23122b/cloudinary-core.js#L4815
  • https://github.com/cloudinary/pkg-cloudinary-core/blob/47ffb3b0c1a163fb1b4e2fc74931c1992a23122b/cloudinary-core.js#L4857

seibert-io avatar Aug 02 '19 15:08 seibert-io