frontend-frameworks icon indicating copy to clipboard operation
frontend-frameworks copied to clipboard

Deep import warning still an issue with the new @cloudinary/ng package

Open bjornharvold opened this issue 3 years ago • 6 comments

Warning when starting [in an Nx environment]

Entry point '@cloudinary/ng' contains deep imports into '/media/user/external/bamboo/xml-data/build-dir/TRAV-SINMRFB-JOB1/node_modules/@cloudinary/url-gen/assets/CloudinaryImage'. This is probably not a problem, but may cause the compilation of entry points to be out of order

bjornharvold avatar Dec 15 '21 02:12 bjornharvold

Thanks @bjornharvold , not a real issue, angular does throw these for a while now : https://github.com/angular/angular/issues/35615

We can't silence these from our side without modifying the import objects (and maybe we will), but there's no harm in this warning.

Leaving this open for future reference and possibly a fix.

patrick-tolosa avatar Dec 15 '21 09:12 patrick-tolosa

Hi @patrick-tolosa ,

May be we can suppress the warning. Like I did it here

https://github.com/indraraj26/ion-camera/blob/master/projects/ion-camera/ngcc.config.js

Thank you

indraraj26 avatar Jun 22 '22 15:06 indraraj26

@indraraj26 It sounds like something that needs to be added to the installing project, and not the SDK itself.

In that case you could probably do that without any worries.

patrick-tolosa avatar Jun 26 '22 07:06 patrick-tolosa

but each time you will install the @cloudinary/ng or any team member, They will have to modify node_modules/@cloudinary package.

It should be done at package level here, You will have to create ngcc.config.js and add the ignore pattern

indraraj26 avatar Jun 26 '22 07:06 indraraj26

Thanks @indraraj26, if you can offer a PR we'll gladly go over it.

patrick-tolosa avatar Jun 26 '22 07:06 patrick-tolosa

Sure Thank you :) @patrick-tolosa

indraraj26 avatar Jun 26 '22 07:06 indraraj26