frontend-frameworks
frontend-frameworks copied to clipboard
Deep import warning still an issue with the new @cloudinary/ng package
Warning when starting [in an Nx environment]
Entry point '@cloudinary/ng' contains deep imports into '/media/user/external/bamboo/xml-data/build-dir/TRAV-SINMRFB-JOB1/node_modules/@cloudinary/url-gen/assets/CloudinaryImage'. This is probably not a problem, but may cause the compilation of entry points to be out of order
Thanks @bjornharvold , not a real issue, angular does throw these for a while now : https://github.com/angular/angular/issues/35615
We can't silence these from our side without modifying the import objects (and maybe we will), but there's no harm in this warning.
Leaving this open for future reference and possibly a fix.
Hi @patrick-tolosa ,
May be we can suppress the warning. Like I did it here
https://github.com/indraraj26/ion-camera/blob/master/projects/ion-camera/ngcc.config.js
Thank you
@indraraj26 It sounds like something that needs to be added to the installing project, and not the SDK itself.
In that case you could probably do that without any worries.
but each time you will install the @cloudinary/ng or any team member, They will have to modify node_modules/@cloudinary package.
It should be done at package level here, You will have to create ngcc.config.js and add the ignore pattern
Thanks @indraraj26, if you can offer a PR we'll gladly go over it.
Sure Thank you :) @patrick-tolosa