cloudinary_npm icon indicating copy to clipboard operation
cloudinary_npm copied to clipboard
verified publisher icon cloudinary

fix: remove dependency on Q

Open v1rtl opened this issue 1 year ago • 2 comments

Brief Summary of Changes

This PR removes a deprecated and outdated Promise library - Q. And replaces it with Promise API and built-ins.

deprecation notice from q:

You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other. (For a CapTP with native promises, see @endo/eventual-send and @endo/captp)

The source now uses the following methods:

  • new Promise() - supported since Node 0.12 and in all browsers (except IE11)
  • Promise.resolve - same as above
  • Promise.reject - same as above

What Does This PR Address?

  • [ ] GitHub issue (Add reference - #XX)
  • [x] Refactoring
  • [ ] New feature
  • [ ] Bug fix
  • [ ] Adds more tests

Are Tests Included?

  • [ ] Yes
  • [x] No, the tests logic didn't change

v1rtl avatar Jun 29 '24 10:06 v1rtl

@talentlessguy PR looks great, thank you for your contribution. Can you please pull latest master? There are some fixes to the CI that need to be included before we can merge.

cloudinary-pkoniu avatar Jul 16 '24 10:07 cloudinary-pkoniu

@cloudinary-pkoniu sure thing

v1rtl avatar Jul 16 '24 11:07 v1rtl