cloudinary_npm icon indicating copy to clipboard operation
cloudinary_npm copied to clipboard

Add colors type to upload response, fix type

Open karlhorky opened this issue 2 years ago • 2 comments

Brief Summary of Changes

  • Add a missing optional colors key to the UploadApiResponse type
  • Fix the type on the ResourceResponseType, as per the docs

What Does This PR Address?

  • [ ] GitHub issue (Add reference - #XX)
  • [ ] Refactoring
  • [ ] New feature
  • [x] Bug fix
  • [ ] Adds more tests

Are Tests Included?

  • [ ] Yes
  • [x] No

Reviewer, Please Note:

If you would prefer the type string instead of using TypeScript template literal types (released in TS 4.1) then I can make this change.

cc @patrick-tolosa

karlhorky avatar May 21 '22 13:05 karlhorky

@karlhorky thanks for the PR.

We'd indeed prefer a string to avoid using TS 4.1, some consumers might still be using old TS versions and thus may run into issues with their tooling.

Once you'll make the change we can review for merging.

patrick-tolosa avatar May 29 '22 10:05 patrick-tolosa

Ok, done in 7b55ce6ae19758652336bb3e7d19ef90c70c7bb0

karlhorky avatar May 29 '22 13:05 karlhorky

@patrick-tolosa would you take another look at this?

karlhorky avatar Nov 01 '22 18:11 karlhorky

Yes of course, sorry I seem to have missed the notification!

patrick-tolosa avatar Nov 02 '22 11:11 patrick-tolosa

No problem, thanks for the merge!

karlhorky avatar Nov 02 '22 11:11 karlhorky