[Bug] @ts-ignore in cloudinary-loader.ts

Open colbyfayock opened this issue 1 year ago • 7 comments

Bug Report

Describe the bug

A @ts-ignore is currently in place in the cloudinaryLoader function which is what organizes and ultimately helps to build a Cloudinary URL based on Next.js props.

https://github.com/cloudinary-community/next-cloudinary/blob/main/next-cloudinary/src/loaders/cloudinary-loader.ts#L58-L59

Goal wouild be to address whatever type issues are preventing this line from being removed.

Jan 25 '24 16:01 colbyfayock

Hi, I'd like to work on this issue

Oct 07 '24 18:10 RaghavMangla

we'll start with the other issue and can work on other issues 1 by 1 unless someone else takes it first. thanks

Oct 08 '24 14:10 colbyfayock

Hi @colbyfayock,

I would love to work on this.

I just completed the #541 PR

Oct 15 '24 12:10 vickywane

sure thing!

Oct 15 '24 12:10 colbyfayock

@colbyfayock I have sent in a PR for this.

Oct 15 '24 13:10 vickywane

:tada: This issue has been resolved in version 7.0.0-beta.10 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Nov 01 '24 19:11 github-actions[bot]

@colbyfayock I think we can close this.

Nov 12 '24 14:11 vickywane