next-cloudinary icon indicating copy to clipboard operation
next-cloudinary copied to clipboard

Dynamic Imports for Video Player

Open colbyfayock opened this issue 2 years ago • 1 comments

Description

This dynamically loads in the Cloudinary Video Player via the npm package.

It makes the version prop that was previously available to control the downloaded assets unavailable due to it now being loaded as a package dependency.

It also copies over assets from the node module, particularly CSS and Fonts (icons) to make available to load from the page adding the player which is needed in the App Router.

Issue Ticket Number

Fixes #180

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Fix or improve the documentation
  • [ ] This change requires a documentation update

Checklist

  • [ ] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • [ ] I have created an issue ticket for this PR
  • [ ] I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • [ ] I have performed a self-review of my own code
  • [ ] I have run tests locally to ensure they all pass
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes needed to the documentation

colbyfayock avatar Apr 25 '23 00:04 colbyfayock

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-cloudinary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2023 3:21pm

vercel[bot] avatar Apr 25 '23 00:04 vercel[bot]