cloudinary-laravel icon indicating copy to clipboard operation
cloudinary-laravel copied to clipboard

No support for Laravel >=9.x: Is the package still maintained?

Open newtonjob opened this issue 1 year ago β€’ 2 comments

Been using this package for a long time, until I realized all my projects are suddenly breaking.

The package can no longer be used from Laravel >= 9.x which uses league/flysystem v3

league/flysystem has since moved to v3, but this CloudinaryAdapter still uses interfaces and traits from v1.

There are several other issues faced by other devs coming down to same problem, e.g.

  • #112
  • #83
  • #114

I am willing to make PRs to update and generally improve the package, but need to know if we still got some eyes here?

newtonjob avatar Jun 21 '24 13:06 newtonjob

Hey @newtonjob, I'm new to the project and have been tasked with bringing this up to date and fixing some bugs and adding new features. I apologize in advance if things look unmaintained as I ramp up and get familiar with the codebase!

joshmanders avatar Jun 21 '24 14:06 joshmanders

Appreciate your response @joshmanders ❀️

newtonjob avatar Jun 21 '24 14:06 newtonjob

yes, it would be great to bring this package live again and with Laravel 10.x too

because we are switching to Cloudinary very soon and I need to use this package for our project 😌

DmitrySidorenkoShim avatar Jul 29 '24 15:07 DmitrySidorenkoShim

we should be cutting a compatibility release for v9 hopefully early this week and a v10+ release soon after!

colbyfayock avatar Jul 29 '24 16:07 colbyfayock

yes, it would be great to bring this package live again and with Laravel 10.x too

because we are switching to Cloudinary very soon and I need to use this package for our project 😌

I've cut a 1.0.6 release that makes it work with Laravel v9 again, this week I will be working on bringing it back to working state with bug fixes and tests to ensure no regressions including compatibility with Laravel 10 and 11.

joshmanders avatar Jul 29 '24 19:07 joshmanders

yes, it would be great to bring this package live again and with Laravel 10.x too because we are switching to Cloudinary very soon and I need to use this package for our project 😌

I've cut a 1.0.6 release that makes it work with Laravel v9 again, this week I will be working on bringing it back to working state with bug fixes and tests to ensure no regressions including compatibility with Laravel 10 and 11.

excuse me, but it is still not working with Laravel 9.x 😌

I wanted to test upload feature with Statamic and 'cloudinary' disk so, I've set up new Laravel project Laravel v9.52.16 installed "cloudinary-labs/cloudinary-laravel": "1.0.6" set up Statamic 4 and everything worked fine until create new asset container with 'cloudinary' disk

my colleague said that he was able to test this at the end of last year but I have this error message now:

Trait "League\Flysystem\Adapter\Polyfill\NotSupportingVisibilityTrait" not found

as you can see from screenshot below Laravel version is 9.x Screenshot 2024-07-30 at 16 47 29

what version have you used for v1.0.6?

DmitrySidorenkoShim avatar Jul 30 '24 14:07 DmitrySidorenkoShim

@DmitrySidorenkoShim can you run composer why league/flysystem and tell me the output?

joshmanders avatar Jul 30 '24 15:07 joshmanders

here you go:

$composer why league/flysystem
laravel/framework      v9.52.16 requires league/flysystem (^3.8.0)    
league/flysystem-local 3.28.0   requires league/flysystem (^3.0.0)    
league/glide           2.3.0    requires league/flysystem (^2.0|^3.0)

DmitrySidorenkoShim avatar Jul 30 '24 17:07 DmitrySidorenkoShim

@joshmanders

to be honest, it is not so important to have it working with Laravel 9.x right now just wanted to check upload with flysystem Cloudinary adapter (and Statamic)

but crucial to have it working with Laravel 10.x as soon as possible in the best case "yesterday" of course πŸ˜„ but next week would be really good too do you think it is possible?

and please let me know if I can help in any way πŸ€”

DmitrySidorenkoShim avatar Aug 01 '24 12:08 DmitrySidorenkoShim

@DmitrySidorenkoShim, if it works for Laravel 9.x, it believe it will also work for 10.x and 11.x

Primary issue is that these Laravel versions now use league/flysystem v3, but the package still uses v1

newtonjob avatar Aug 01 '24 12:08 newtonjob

@DmitrySidorenkoShim, if it works for Laravel 9.x, it believe it will also work for 10.x and 11.x

Primary issue is that these Laravel versions now use league/flysystem v3, but the package still uses v1

This is the issue, and I'm working on it @DmitrySidorenkoShim. See https://github.com/cloudinary-community/cloudinary-laravel/pull/123

joshmanders avatar Aug 01 '24 17:08 joshmanders

hi @joshmanders

sorry for annoying you but is there any good news? 😌

DmitrySidorenkoShim avatar Aug 07 '24 07:08 DmitrySidorenkoShim

hi @joshmanders

sorry for annoying you but is there any good news? 😌

Not annoying at all. Working through some stuff now and will hopefully have a release this weekend, Monday at the latest.

joshmanders avatar Aug 07 '24 21:08 joshmanders

hi @joshmanders

I am just wondering if it isn’t ready yet? πŸ˜„

DmitrySidorenkoShim avatar Aug 13 '24 10:08 DmitrySidorenkoShim

@DmitrySidorenkoShim I published v2.2.0 yesterday which should make it work in Laravel 10 and 11. Go ahead and give it a try and if you see any problems, please open a new issue so I can address it.

joshmanders avatar Aug 13 '24 14:08 joshmanders

Huge thanks for your work on this @joshmanders!

newtonjob avatar Aug 14 '24 14:08 newtonjob