cloudify-stage icon indicating copy to clipboard operation
cloudify-stage copied to clipboard

RD-6162 Merged `widgets/common` into main application bundle

Open kubama opened this issue 2 years ago • 1 comments

Description

Merged widgets/common into main application bundle

Screenshots / Videos

N/A

Checklist

  • [X] My code follows the UI Code Style.
  • [ ] I followed the UI Testing Guidelines and verified that all tests/checks have passed.
  • [X] I verified if that change requires any update in the documentation.
  • [X] I added proper labels to this PR.

Tests

https://jenkins.cloudify.co/view/UI/job/Stage-UI-System-Test/4078/ - the tests are starting and running, failures due to environment issues.

Component tests are failing on first spec - application bundle now takes slightly longer to build, thus the timeout. I consider it an unacceptable CI slowness - it takes 195s to build the bundle on CI while only 25s locally - almost 8x slower. I consider https://cloudifysource.atlassian.net/browse/RD-6549 a blocker to this ticket.

Documentation

N/A

kubama avatar Dec 09 '22 10:12 kubama

I think that as we are moving out from using Stage global object in built-in widgets, we would need stronger verification for it in tests. That'll ensure that we don't brake custom widget development. Can we make it part of RD-6346 epic? (either within already existing ticket or a new one)

I think this should be done as part of RD-6564. I'll extend its description to make it clear.

kubama avatar Dec 12 '22 12:12 kubama

@bartoszkosciug made pipeline changes that solved the timeout issue. Re-approval needed.

kubama avatar Dec 14 '22 12:12 kubama