uaa icon indicating copy to clipboard operation
uaa copied to clipboard

Fix regression with legacy redirect patterns

Open strehle opened this issue 3 years ago • 2 comments

Port wildcards were working, but because of spring change this fails now Bring it back now with this PR.

Remark: legacy patterns were in past and again now written to log with warnings, so that you see them

Example WARN --- LegacyRedirectResolver: OAuth client app is configured with a redirect_uri which performs implicit or wildcard matching in legacy redirect uri matching mode. In this instance, the requested uri http://localhost:3000/authentication/callback matches the configured uri http://localhost:*/authentication/callback. Please consider configuring your requested redirect uri to exactly match the redirect_uri for this client.

strehle avatar Sep 22 '22 10:09 strehle

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/183350365

The labels on this github issue will be updated when the story is started.

cf-gitbot avatar Sep 22 '22 10:09 cf-gitbot

@torsten-sap this features was requested from SAP but obviously no more clients with port pattern are used, so did you received any issues here ? The regression must be there since some version.... have to check which spring update caused it but with this PR it should work again

strehle avatar Sep 22 '22 10:09 strehle

sonar https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=2035

strehle avatar Sep 23 '22 14:09 strehle

Looks good to me, @peterhaochen47, @bruce-ricard.

hsinn0 avatar Sep 27 '22 21:09 hsinn0