stratos icon indicating copy to clipboard operation
stratos copied to clipboard

Should be buildable without package-lock.json

Open cache-sk opened this issue 3 years ago • 0 comments

Stratos Version

4.4.0 release

Frontend Deployment type

  • [x] Other (please specify below) - NONE

Backend (Jet Stream) Deployment type

  • [x] Other (please specify below) - NONE

Expected behaviour

npm install should pass without existing package-lock.json

Actual behaviour

npm install fail due dependency conflict

Steps to reproduce the behavior

Unpack clean 4.4.0 zip release, delete package-lock.json and run npm install with npm 7.0.14 and node v15.3.0 (or possibly newer)

Log output covering before error and any error statements

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/flex-layout
npm ERR!   @angular/flex-layout@"^10.0.0-beta.32" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/flex-layout@">=9.0.0-beta.28" from @cfstratos/[email protected]
npm ERR! node_modules/@cfstratos/ajsf-material
npm ERR!   @cfstratos/ajsf-material@"^0.1.6" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Detailed Description

We have recently updated our gitlab runner to npm 7.0.14 and node v15.3.0 (from versions 6.something and node version v14.something).
We do not store (til today) package-lock.json in git - i know it is recomended, but not necessary, it should be generated during npm install.
With older npm/node, everything works, but after update, npm install raise dependency conflict between @angular/flex-layout@^10.0.0-beta.32 used by stratos and @angular/flex-layout@^9.0.0-beta.29 used by @cfstratos/ajsf-material@^0.1.6, which is used by stratos.

Possible Implementation

Update @cfstratos/ajsf-material to use same version as stratos itself.

cache-sk avatar Mar 10 '21 14:03 cache-sk