go-cfclient icon indicating copy to clipboard operation
go-cfclient copied to clipboard

Fix PaidServicesAllowed to type bool

Open fapo85 opened this issue 1 year ago • 1 comments

The Cloud Controller API states that the PaidServicesAllowed field must not be null. The field should be a boolean and not a *bool (pointer). https://v3-apidocs.cloudfoundry.org/version/3.180.0/index.html#the-organization-quota-object

This way, the calling application can assume that it is not nil. The other fields are designated as nullable or pointers and thus defined as unlimited. This makes no sense for a boolean.

Other use cases also follow this pattern: pointer = nullable, otherwise value.

Therefore, I assume that this is a bug, which I fix with this PR.

Currently, the command make all throws lint warnings, which also happens to me in the main branch.

fapo85 avatar Oct 30 '24 17:10 fapo85

CLA Not Signed

LGTM, I can merge it if you sign the CLA

sneal avatar Nov 13 '24 17:11 sneal

as a little time has already passed, a short feedback. We are currently clarifying internally why this has not yet happened or does not count.

fapo85 avatar Dec 02 '24 06:12 fapo85

i have indications that my company has signed the cla, i will test it

fapo85 avatar Feb 04 '25 06:02 fapo85

Fixed in main

sneal avatar Feb 12 '25 21:02 sneal