go-cfclient icon indicating copy to clipboard operation
go-cfclient copied to clipboard

Published 20 hours ago • verified publisher icon cloudfoundry

Service instance update request

Open elgohr opened this issue 6 years ago • 8 comments

Introduce struct for simpler usage

elgohr avatar Nov 27 '18 18:11 elgohr

Ping

elgohr avatar Jan 12 '19 18:01 elgohr

I like the idea of this PR, but it would be a breaking change. Can you think of any ways to introduce this in such a way that it wouldn't break anything?

jghiloni avatar Jan 14 '19 20:01 jghiloni

We could have both, but this would be more code to maintain. Furthermore this method is an exception in terms of behavior (other methods already use custom structs as attributes). In this way I would vote for breaking.

elgohr avatar Jan 15 '19 04:01 elgohr

This fix was introduced less than a week after the initial introduction of the method. The longer this layes around, the more people will break...

elgohr avatar Feb 27 '19 18:02 elgohr

it would be a breaking change

What's wrong with a breaking change so long as there's a version bump?

siennathesane avatar Jun 06 '19 21:06 siennathesane

Ping

elgohr avatar Dec 26 '19 21:12 elgohr

@jghiloni poke

siennathesane avatar Dec 26 '19 22:12 siennathesane

If we can make this a backwards compatible change I'll merge it.

sneal avatar Mar 22 '21 15:03 sneal

service instance update support added in v3 branch

sneal avatar Nov 08 '22 22:11 sneal