eirini-release icon indicating copy to clipboard operation
eirini-release copied to clipboard

Unify the code generation tools in our controllers

Open kieron-dev opened this issue 3 years ago • 1 comments

Our hack script invokes two scripts:

  • vendor/k8s.io/code-generator/generate-groups.sh, which generates
    • the deepcopy functions
    • the versioned client
    • listers
    • informers
  • vendor/sigs.k8s.io/controller-tools/cmd/controller-gen, which generates
    • CRDs

Kubebuilder only uses controller-tools. We should follow that example.

Note: this means adopting the controller-runtime client, as we wouldn't be generating the client originally used in eirini. If that's not possible, we can drop this chore.

kieron-dev avatar Jun 08 '21 08:06 kieron-dev

Before we can work on this story, we'll need to remove all dependencies on the old eirini codebase and the clientset. Blocking for now.

gcapizzi avatar Jun 08 '21 13:06 gcapizzi