cloud_controller_ng icon indicating copy to clipboard operation
cloud_controller_ng copied to clipboard
verified publisher icon cloudfoundry

Ruby 3.3

Open sethboyles opened this issue 1 year ago • 2 comments

https://github.com/cloudfoundry/cloud_controller_ng/issues/3559

  • [ ] I have reviewed the contributing guide

  • [ ] I have viewed, signed, and submitted the Contributor License Agreement

  • [ ] I have made this pull request to the main branch

  • [ ] I have run all the unit tests using bundle exec rake

  • [ ] I have run CF Acceptance Tests

sethboyles avatar Nov 04 '24 22:11 sethboyles

I wonder if we should pre-emptively run https://github.com/cloudfoundry/cf-performance-tests against this change to see if theres any noticeable positive/negative effect.

Samze avatar Nov 05 '24 19:11 Samze

Wouldn't hurt, I suppose. If we are starting to care about pre-release data, maybe we should have cf-performance-tests that run on prereleases, not just after capi is bumped in cf-deployment?

That said, I think most of our issues are due to DB queries, so I would be surprised if this makes a significant impact. If Ruby code turns out to have a big impact maybe we should push the BOSH team get Rust in the bosh ruby package so we can turn on YJIT

sethboyles avatar Nov 07 '24 19:11 sethboyles