cloud_controller_ng icon indicating copy to clipboard operation
cloud_controller_ng copied to clipboard

Remove mysql 5.7 from unit tests

Open stephanme opened this issue 1 year ago • 3 comments

  • A short explanation of the proposed change:

Take out mysql 5.7 from the unit test matrix as it is explicitly not supported for cf-deployment.

  • An explanation of the use cases your change solves

Allows to use mysql features and rely on bug fixes that are not available in mysql 5.7. Example: Dropping of duplicated unique constraints in DB migrations.

  • Links to any other associated PRs

Fixes #3949 and unblocks #3952

  • [x] I have reviewed the contributing guide

  • [x] I have viewed, signed, and submitted the Contributor License Agreement

  • [x] I have made this pull request to the main branch

  • [ ] I have run all the unit tests using bundle exec rake

  • [ ] I have run CF Acceptance Tests

stephanme avatar Oct 11 '24 09:10 stephanme

Our preference would be to hold off on this until May, as we support foundations using MySQL 5.7 until then.

sethboyles avatar Oct 11 '24 17:10 sethboyles

OK, we need then to adapt #3949 to work with mysql 5.7. Labeled it as blocked until May 2025.

stephanme avatar Oct 14 '24 16:10 stephanme

Our support date for MySQL 5.7 is actually 2025-07-31 so perhaps we pause this until then?

Samze avatar May 27 '25 16:05 Samze

@sethboyles @Samze Can we proceed on this? 2025-07-31 is over 😉

johha avatar Aug 20 '25 12:08 johha

Yes, please go ahead.

sethboyles avatar Aug 20 '25 20:08 sethboyles

(and thank you for your patience)

sethboyles avatar Aug 20 '25 20:08 sethboyles