cloud_controller_ng icon indicating copy to clipboard operation
cloud_controller_ng copied to clipboard

Published 20 hours ago • verified publisher icon cloudfoundry

Start dropping vip

Open moleske opened this issue 10 months ago • 6 comments

  • migration needed to drop vip, I apparently can't remember how to write migrations in ruby

#3712

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

  • An explanation of the use cases your change solves

  • Links to any other associated PRs

  • [x] I have reviewed the contributing guide

  • [x] I have viewed, signed, and submitted the Contributor License Agreement

  • [x] I have made this pull request to the main branch

  • [x] I have run all the unit tests using bundle exec rake

  • [ ] I have run CF Acceptance Tests

moleske avatar Apr 21 '24 16:04 moleske

@moleske regarding the database migration you mentioned. I think you may need to leave the vip_offset column on the routes for some time, otherwise it might cause route creation/update failures during upgrades.

Maybe add a timebomb test to remind us to remove it in the distant future? Example: https://github.com/cloudfoundry/cloud_controller_ng/commit/7c322ce1d7e9e977049420e450af79056ed02697

tcdowney avatar May 14 '24 20:05 tcdowney

I might skip the time bomb test cause it is unlikely I'll do something when it goes off. Though if others would like it I'll add it. Now that I see https://github.com/cloudfoundry/capi-ci/pull/52 I'll try to actually run cats against (assuming I can actually get an environment)

moleske avatar May 15 '24 02:05 moleske

I tried to claim a bosh lite but it seems to think there are none available. I left a message in the capi slack channel asking if I was just doing it wrong. I was able to create a bosh release with https://github.com/cloudfoundry/capi-release/pull/419 but wasn't able to test if it deployed successfully due to the inability to claim a bosh lite. If someone else is able to give a whirl and run cats that would be helpful, or let me know how to correctly claim a bosh lite

moleske avatar May 24 '24 22:05 moleske

putting back in draft as I got a bosh lite and cats is failing. wonder if it is cf networking needing this or something else going on

moleske avatar May 25 '24 01:05 moleske

Edit - See latest comment here, bosh lite is working now!

I'm reopening this for review. I'm having trouble with the bosh lite environment though, as even an unmodified capi version is causing me multiple bosh lite test failures (86!) with cf acceptance test version 16.4.0

maybe @Gerg has some suggestions on what I'm doing wrong with bosh lites, but will save that sort of conversation for slack. Would be thrilled to have others review this though. Will keep playing with bosh lite and see if I'm just doing something terrible in my windows subsystem for linux environment

moleske avatar Jun 09 '24 19:06 moleske

Got this working on a bosh lite! cf acceptance test 16.4.0 is passing with the config generated. bosh lite is regent in the capi pool for those curious. Could use some reviews from folks next time you're passing through

moleske avatar Jul 30 '24 06:07 moleske