cloud_controller_ng icon indicating copy to clipboard operation
cloud_controller_ng copied to clipboard

Published 20 hours ago • verified publisher icon cloudfoundry

Fix flakey test in droplets.spec

Open svkrieger opened this issue 2 years ago • 0 comments

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

The test failed (https://github.com/cloudfoundry/cloud_controller_ng/runs/7670613025?check_suite_focus=true) because the generated expected droplet URL is based on the current timestamp. Depending on the test execution speed, it can differ from the timestamp in the URL, which was generated during the request.

Fixed by using Timecop.freeze, which ensures that both URLs will have the same timestamp.

  • [x] I have reviewed the contributing guide

  • [x] I have viewed, signed, and submitted the Contributor License Agreement

  • [x] I have made this pull request to the main branch

  • [x] I have run all the unit tests using bundle exec rake

  • [ ] I have run CF Acceptance Tests

svkrieger avatar Aug 04 '22 11:08 svkrieger