Make route destinations ordering consistent

[sethboyles]

• This inconsistency mostly causes several flakey tests

Co-authored-by: Seth Boyles [email protected] Co-authored-by: Michael Oleske [email protected]

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

• A short explanation of the proposed change:

• An explanation of the use cases your change solves

• Links to any other associated PRs

• [x] I have reviewed the contributing guide

• [x] I have viewed, signed, and submitted the Contributor License Agreement

• [x] I have made this pull request to the main branch

• [x] I have run all the unit tests using bundle exec rake

• [ ] I have run CF Acceptance Tests

[sethboyles]

Two other PRs that attempted to address the issue, in the past we decided not to make ordering consistent in favor of just fisting the tests, but these keep cropping up:

https://github.com/cloudfoundry/cloud_controller_ng/pull/2751 https://github.com/cloudfoundry/cloud_controller_ng/pull/2752

[moleske]

I retract my previous comment and say sort them now after the fun times the past few months of seeing this flake every once in a long while