cloud_controller_ng icon indicating copy to clipboard operation
cloud_controller_ng copied to clipboard

label_selector parser is too draconian re white-space

Open ericpromislow opened this issue 6 years ago • 2 comments

See also https://github.com/cloudfoundry/cloud_controller_ng/issues/1443

Summing up 5 known issues:

Given this label_selector: environment in (production, staging), tier=backend

There are at least 4 known errors related to white-space handling:

  1. Space required before open-paren:
environment in(production, staging), tier=backend
                        ^
  1. Space forbidden inside comma-separated in-block (issue #1443):
environment in (production, staging), tier=backend
                                             ^
  1. Space forbidden after and-type comma:
environment in (production, staging), tier=backend
                                                             ^
  1. Spaces forbidden around equal-sign:
environment in (production, staging), tier =backend
                                                                   ^
  1. Trailing spaces forbidden
environment in (production, staging), tier=backend[SPACE]
                                                                                   ^
  1. Leading spaces forbidden
[SPACE]environment in (production, staging), tier=backend
^

The examples in the Kub document appear more forgiving of white-space. They don't talk about it, at least

ericpromislow avatar Sep 13 '19 19:09 ericpromislow

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/168488761

The labels on this github issue will be updated when the story is started.

cf-gitbot avatar Sep 13 '19 19:09 cf-gitbot

I'm working on this during flex time, so if anyone else wants to work on this pls contact me

ericpromislow avatar Sep 16 '19 22:09 ericpromislow