cli icon indicating copy to clipboard operation
cli copied to clipboard
verified publisher icon cloudfoundry

Add "total_domains" to quota json unmarshalling

Open sleungcy-sap opened this issue 1 year ago • 3 comments

Where this PR should be backported?

  • [x] main - all changes should by default start here
  • [x] v8
  • [x] v7

Description of the Change

Consumers of this library can access the total_domains field from the api with this change.

Why Is This PR Valuable?

The value of total_domains is not included into unmarshalled data and is missing at the moment. The value should be available from the API as documented in https://v3-apidocs.cloudfoundry.org/version/3.163.0/#organization-quotas-in-v3

Applicable Issues

How Urgent Is The Change?

Other Relevant Parties

sleungcy-sap avatar Apr 24 '24 20:04 sleungcy-sap

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: sleungcy-sap / name: Sam Leung (29801d83de95921bccd966e45c4257cd9a2e726e)

linux-foundation-easycla[bot] avatar Apr 24 '24 20:04 linux-foundation-easycla[bot]

@sleungcy-sap We had some environment issues and integration tests did not run. Can you please update the branch and reopen the PR?

gururajsh avatar May 01 '24 15:05 gururajsh

Can you please create separate PRs for v8 and v7

gururajsh avatar May 01 '24 15:05 gururajsh