cli
cli copied to clipboard
GitHub Actions Integration Tests
Description of the Change
This introduces CF CLI integration tests
I propose to have workflow names use shared namespace-like prefixes. For example
Current | Proposed |
---|---|
.github/workflows/setup-cf-env.yml | .github/workflows/cf-env-setup.yml |
.github/workflows/unclaim-cf-env.yml | .github/workflows/cf-env-unclaim.yml |
Chatted with @ccjaimes about this. The integration tests are now running. There are some test failures, but we think there is value in getting this merged so we can start seeing if tests are flaky and how we feel about the tests running here. We don't think these integration tests should be a blocker to merging PRs until we fix the known test failures. We'll start opening other PRs to fix the test failures.
Here's a list of the test failures we've seen so far
-
route_sharing
feature is not enabled by the tests that need them -
src/code.cloudfoundry.org/cli/integration/helpers/fixtures/fifty-spaces-org.json
is a hard coded path in some tests - some tests failed at using isolation segments
Once those test failures are addressed, then we can make passing the integration tests a blocker for PRs
If things go really wrong, we can always roll back or disable these integration tests cc @cloudfoundry/wg-app-runtime-interfaces-cli-approvers & @cloudfoundry/wg-app-runtime-interfaces-cli-reviewers for comment