cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: add tip to restart app when enabling ssh

Open wanddynosios opened this issue 2 years ago • 1 comments

Does this PR modify CLI v6, CLI v7, or CLI v8?

v8

Description of the Change

This PR adds a 'TIP' to restart the app when enabling ssh:

➜  out git:(v8) ✗ ./cf-cli_macosarm disable-ssh my-app
Disabling ssh support for app my-app as my-user...
OK

➜  out git:(v8) ✗ ./cf-cli_macosarm enable-ssh my-app 
Enabling ssh support for app my-app as my-user...
OK

TIP: An app restart is required for the change to take effect.
➜  out git:(v8) ✗ ./cf-cli_macosarm enable-ssh my-app
Enabling ssh support for app my-app as my-user...
ssh support for app 'my-app' is already enabled.
OK

TIP: An app restart may be required for the change to take effect.

Complies with style guide

Why Is This PR Valuable?

As a cloud foundry operator I often get questions from customers about cf ssh "not working", because it is not obvious that a restart is necessary.

Why Should This Be In Core?

Applicable Issues

https://github.com/cloudfoundry/cli/issues/2133#issuecomment-855917538

How Urgent Is The Change?

Other Relevant Parties

wanddynosios avatar Sep 09 '22 11:09 wanddynosios

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: wanddynosios (7a10672e258cd6fbe9e12d07a1cb4bbc4ab9ab14, fcc3a342f93da56ddcd0695db23d7a94cccac04c, e72176d8cf8b4a98a1c594f25a1eed58e8327169)

@a-b I created https://github.com/cloudfoundry/cli/pull/2360 and https://github.com/cloudfoundry/cli/pull/2361.

Thanks!

wanddynosios avatar Dec 14 '22 09:12 wanddynosios

I'm wondering what is missing to get this in?

beyhan avatar Apr 14 '23 14:04 beyhan

I'm wondering what is missing to get this in?

So am I. The PR has been reviewed a while ago already.

wanddynosios avatar Jun 15 '23 07:06 wanddynosios

I also asked in the CLI Slack channel https://cloudfoundry.slack.com/archives/C032824SM/p1686818021365519

beyhan avatar Jun 15 '23 08:06 beyhan