cf-java-client icon indicating copy to clipboard operation
cf-java-client copied to clipboard

Published 20 hours ago • verified publisher icon cloudfoundry

Implement Manifest V3 objects and deployment

Open schulzh opened this issue 2 years ago • 5 comments

Implements:

  • objects and logic required for reading and writing CC API V3 manifests
  • client interface and reactor implementation to apply the manifest
  • resource matching for v3 packages API
  • pushManifestV3 operation, similar to the existing pushManifest operation

I hope that the pushManifestV3 operation is complete (especially the "app readiness" checks), since I did not find a documentation of this process and had to reverse engineer it from the CLI.

I chose to pass a raw byte array as manifest in the client instead of an object, because that would've required to add the snakeyaml dependency to the client as well. Since the manifest is just passed to and applied by the CC anyway, I saw no benefit of passing as an object.

Unfortunately, I could not get a local CF instance set up for the integration tests. Due to licensing issues at my company I cannot use Virtualbox and setting it up on a local OpenStack "DevStack" instance wasn't working either. If requested, I can add integration tests, but I cannot ensure that they are working as intended.

Solves #999 and #1142 but not #1103 yet

schulzh avatar Sep 16 '22 10:09 schulzh

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: schulzh / name: Hans Schulz (e88310640bc86d5c2f7a726ff8099ebd20daae08)

linux-foundation-easycla[bot] avatar Sep 16 '22 10:09 linux-foundation-easycla[bot]

Thanks for the PR @schulzh! Are you able to follow the link in the EasyCLA comment above to get the commit authorised ✅ and satisfy the bot?

SInce this is a significant addition, if you can add the integration tests I am happy to run them in a lab!

pivotal-david-osullivan avatar Sep 16 '22 13:09 pivotal-david-osullivan

I have already done the EasyCLA process and I'm waiting on the approval of my organization. I'll add integration tests then, thanks!

schulzh avatar Sep 16 '22 13:09 schulzh

Hi @pivotal-david-osullivan,

I've added integration tests. Could you please run them in your lab? I've also completed the CLA. From my side this PR should be ready to merge, so I'd be happy to have it reviewed.

schulzh avatar Sep 21 '22 13:09 schulzh

Hi @mheath ,

Thank you for the review and kind words :slightly_smiling_face:

I've addressed the issues, please take a look.

schulzh avatar Oct 06 '22 13:10 schulzh

Will you change the branch from main to manifest-v3 on this PR and I will get it merged and then merge in my acceptance tests?

mheath avatar Oct 21 '22 20:10 mheath

Hi @mheath,

I've changed the base branch. It looks like its lagging behind main a few hounded commits. Should I rebase it?

schulzh avatar Oct 22 '22 00:10 schulzh

Hello @mheath,

do you have any updates on this? What is missing to get it merged to master?

schulzh avatar Jan 17 '23 10:01 schulzh